iMDS Bid Adapter: support gpp #10150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…synacormedia adapter to imds
CAPT-787: Add gpp support to prebid.js imds adapter. Approved-by: Andrew Fuchs
8 tasks
patmmccann
reviewed
Jun 27, 2023
modules/imdsBidAdapter.js
Outdated
| const tmax = bidderRequest.timeout; | ||
| const callbackTimeout = bidderRequest.timeout; | ||
| const globalTimeout = config.getConfig('bidderTimeout'); | ||
| const tmax = globalTimeout ? Math.min(globalTimeout, callbackTimeout) : callbackTimeout; |
There was a problem hiding this comment.
this is incorrect, just use the value in the request
There was a problem hiding this comment.
this is incorrect, just use the value in the request
Okay, I was wondering how #8526 somehow disappeared.
…name of synacormedia adapter to imds" This reverts commit 6619ed9.
ChrisHuie
approved these changes
Jul 20, 2023
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Backport of pull request prebid#8526 that was missing from rename of synacormedia adapter to imds * CAPT-787: Add gpp support to imds adapter. * CAPT-787: Change src= to pbjs/x.y.z to be consistent with prebid-server format. * CAPT-787: Add gppsid parameter to usersync to mirror the prebid-server instance * Revert "Backport of pull request prebid#8526 that was missing from rename of synacormedia adapter to imds" This reverts commit 6619ed9. * CAPT-787: imds adapter: Resolve "undefined" passed in gpp string for usersync --------- Co-authored-by: Timothy M. Ace <tace@imds.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
GPP support is added to the iMDS bid adapter